Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating all-in-one path #4234

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

bigfleet
Copy link
Contributor

Signed-off-by: Jim Van Fleet jim@jimvanfleet.com

Which problem is this PR solving?

Short description of the changes

  • Updating the document to include the updated all-in-one path
  • Adding one additional comment for those not briefed on kustomize

Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>
@bigfleet bigfleet requested a review from a team as a code owner February 13, 2023 13:17
@bigfleet bigfleet requested a review from joe-elliott February 13, 2023 13:17
@yurishkuro yurishkuro merged commit 5b58370 into jaegertracing:main Feb 13, 2023
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Feb 22, 2023
Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>

## Which problem is this PR solving?
- Resolves jaegertracing#4230 

## Short description of the changes
- Updating the document to include the updated all-in-one path
- Adding one additional comment for those not briefed on kustomize

Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>

## Which problem is this PR solving?
- Resolves jaegertracing#4230

## Short description of the changes
- Updating the document to include the updated all-in-one path
- Adding one additional comment for those not briefed on kustomize

Signed-off-by: Jim Van Fleet <jim@jimvanfleet.com>
Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HotRod example fails documented kustomize build
2 participants